feat(site-kit): flag locale menu variant + flag data (D-017) - #30
Merged
Conversation
Vendored from flag-icons 7.5.0 (MIT) and inlined by scripts/build-flags.mjs. Flags are site-kit data, not dds-icons entries: the icon set's contract bans colour literals and requires currentColor strokes.
A details/summary disclosure — flag-only trigger, fourteen flag + native name links — that works without JavaScript; Solid adds Escape, focus return and the onLocaleChange contract. The select variant is unchanged and stays the default. SiteHeader passes localeVariant through.
This was referenced Sep 2, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
LocaleMenu variant="flag": flag-only trigger, fourteen flag + native-name rows, native<details>so it works without JavaScript; Solid adds Escape, focus return,onLocaleChange.src/core/flags.mjs, vendored from flag-icons 7.5.0 (MIT). Not indds-icons: its contract bans colour literals (D-017).SiteHeaderforwardslocaleVariant. Theselectvariant is unchanged and remains the default.Verification
verify:site-kit:ui,verify:site-kit:browser(new flag disclosure spec at 1280/375, RTL, hit-test),verify:site-kit:release,verify— all green locally.First consumer
TraceLinq landing (gettracelinq.app) — consumes 0.4.0 from npm.